Changeset 39409 for trunk/tests/phpunit/tests/ajax/CustomizeManager.php

Timestamp:

12/02/2016 12:01:51 AM (8 years ago)

Author:

westonruter

Message:

Customize: Reject a changeset update when a non-future date is provided and also ensure that a published changeset always gets set to the current date/time.

• Also moves checks from customize_save Ajax handler to the underlying WP_Customize_Manager::save_changeset_post() call which plugins may invoke directly.
• Ensures that customize_save_response filter is always passed an array, with error code available as code.

Props utkarshpatel, westonruter, sayedwp.
See #30937.
Fixes #38943.

File:

• trunk/tests/phpunit/tests/ajax/CustomizeManager.php (modified) (3 diffs)

trunk/tests/phpunit/tests/ajax/CustomizeManager.php

@@ -165 +165 @@
         $this->make_ajax_call( 'customize_save' );
         $this->assertFalse( $this->_last_response_parsed['success'] );
-        $this->assertEquals( 'changeset_already_published', $this->_last_response_parsed['data'] );
+        $this->assertEquals( 'changeset_already_published', $this->_last_response_parsed['data']['code'] );
         wp_update_post( array( 'ID' => $wp_customize->changeset_post_id(), 'post_status' => 'auto-draft' ) );
 
@@ -214 +214 @@
         $this->make_ajax_call( 'customize_save' );
         $this->assertFalse( $this->_last_response_parsed['success'] );
-        $this->assertEquals( 'not_future_date', $this->_last_response_parsed['data'] );
+        $this->assertEquals( 'not_future_date', $this->_last_response_parsed['data']['code'] );
         $_POST['customize_changeset_date'] = ( gmdate( 'Y' ) + 1 ) . '-01-01 00:00:00';
         $this->make_ajax_call( 'customize_save' );
@@ -308 +308 @@
         $this->assertEquals( 'Published', get_post( $post_id )->post_title );
     }
+
+    /**
+     * Test WP_Customize_Manager::save().
+     *
+     * @ticket 38943
+     * @covers WP_Customize_Manager::save()
+     */
+    function test_success_save_post_date() {
+        $uuid = wp_generate_uuid4();
+        $post_id = $this->factory()->post->create( array(
+            'post_name' => $uuid,
+            'post_title' => 'Original',
+            'post_type' => 'customize_changeset',
+            'post_status' => 'auto-draft',
+            'post_content' => wp_json_encode( array(
+                'blogname' => array(
+                    'value' => 'New Site Title',
+                ),
+            ) ),
+        ) );
+        $wp_customize = $this->set_up_valid_state( $uuid );
+
+        // Success future schedule date.
+        $future_date = ( gmdate( 'Y' ) + 1 ) . '-01-01 00:00:00';
+        $_POST['customize_changeset_status'] = 'future';
+        $_POST['customize_changeset_title'] = 'Future date';
+        $_POST['customize_changeset_date'] = $future_date;
+        $this->make_ajax_call( 'customize_save' );
+        $this->assertTrue( $this->_last_response_parsed['success'] );
+        $changeset_post_schedule = get_post( $post_id );
+        $this->assertEquals( $future_date, $changeset_post_schedule->post_date );
+
+        // Success future changeset change to draft keeping existing date.
+        unset( $_POST['customize_changeset_date'] );
+        $_POST['customize_changeset_status'] = 'draft';
+        $this->make_ajax_call( 'customize_save' );
+        $this->assertTrue( $this->_last_response_parsed['success'] );
+        $changeset_post_draft = get_post( $post_id );
+        $this->assertEquals( $future_date, $changeset_post_draft->post_date );
+
+        // Success if date is not passed with schedule changeset and stored changeset have future date.
+        $_POST['customize_changeset_status'] = 'future';
+        $this->make_ajax_call( 'customize_save' );
+        $this->assertTrue( $this->_last_response_parsed['success'] );
+        $changeset_post_schedule = get_post( $post_id );
+        $this->assertEquals( $future_date, $changeset_post_schedule->post_date );
+        // Success if draft with past date.
+        $now = current_time( 'mysql' );
+        wp_update_post( array(
+            'ID' => $post_id,
+            'post_status' => 'draft',
+            'post_date' => $now,
+            'post_date_gmt' => get_gmt_from_date( $now ),
+        ) );
+
+        // Fail if future request and existing date is past.
+        $_POST['customize_changeset_status'] = 'future';
+        unset( $_POST['customize_changeset_date'] );
+        $this->make_ajax_call( 'customize_save' );
+        $this->assertFalse( $this->_last_response_parsed['success'] );
+        $this->assertEquals( 'not_future_date', $this->_last_response_parsed['data']['code'] );
+
+        // Success publish changeset reset date to current.
+        wp_update_post( array(
+            'ID' => $post_id,
+            'post_status' => 'future',
+            'post_date' => $future_date,
+            'post_date_gmt' => get_gmt_from_date( $future_date ),
+        ) );
+        unset( $_POST['customize_changeset_date'] );
+        $_POST['customize_changeset_status'] = 'publish';
+        $this->make_ajax_call( 'customize_save' );
+        $this->assertTrue( $this->_last_response_parsed['success'] );
+        $changeset_post_publish = get_post( $post_id );
+        $this->assertNotEquals( $future_date, $changeset_post_publish->post_date );
+    }
 }