Changeset 39413 for trunk/src/wp-content/themes/twentyseventeen/template-parts/header/header-image.php

Timestamp:

12/02/2016 05:11:56 AM (9 years ago)

Author:

joemcgill

Message:

Twenty Seventeen: Better handling of custom headers when no image is set.

This ensures that a standard header is shown on the front page whenever
a header video is set without a header image if the video doesn't load,
e.g., on mobile sizes or if the JS doesn't fire.

This adds a new class, .has-header-video that is added whenever the
wp-custom-header-video-loaded event is fired, which is then used to style
the custom headers along with .has-header-image whenever a header image
is available. This also changes the class name on the custom header media
wrapping div from .custom-header-image to .custom-header-media.

Props laurelfulford, joemcgill.
Fixes #38995.

File:

• trunk/src/wp-content/themes/twentyseventeen/template-parts/header/header-image.php (modified) (2 diffs)

trunk/src/wp-content/themes/twentyseventeen/template-parts/header/header-image.php

@@ -1 +1 @@
 <?php
 /**
- * Displays header image
+ * Displays header media
  *
  * @package WordPress
@@ -12 +12 @@
 <div class="custom-header">
 
-    <?php if ( has_custom_header() ) : ?>
-        <div class="custom-header-image">
+        <div class="custom-header-media">
             <?php the_custom_header_markup(); ?>
         </div>
-    <?php endif; ?>
 
     <?php get_template_part( 'template-parts/header/site', 'branding' ); ?>