Changeset 39423

Timestamp:

12/02/2016 06:33:25 AM (8 years ago)

Author:

helen

Message:

Twenty Seventeen: Fix broken menu toggle in Customizer after menu items are added

This simplifies the line $( siteNavigation.closest( '.main-navigation' ), this ).toggleClass( 'toggled-on' ); to $( siteNavContain ).toggleClass( 'toggled-on' );, since this is the clicked button, so the extra context isn't needed.

Props afercia, laurelfulford.

Fixes #38992 for the 4.7 branch.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentyseventeen/assets/js/navigation.js (modified) (3 diffs)

branches/4.7/src/wp-content/themes/twentyseventeen/assets/js/navigation.js

@@ -7 +7 @@
 
 (function( $ ) {
-    var masthead, menuToggle, siteNavigation;
+    var masthead, menuToggle, siteNavContain, siteNavigation;
 
     function initMainNavigation( container ) {
@@ -40 +40 @@
     masthead       = $( '#masthead' );
     menuToggle     = masthead.find( '.menu-toggle' );
+    siteNavContain = masthead.find( '.main-navigation' );
     siteNavigation = masthead.find( '.main-navigation > div > ul' );
 
@@ -54 +55 @@
 
         menuToggle.on( 'click.twentyseventeen', function() {
-            $( siteNavigation.closest( '.main-navigation' ), this ).toggleClass( 'toggled-on' );
+            $( siteNavContain ).toggleClass( 'toggled-on' );
 
             $( this )