Changeset 39464 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

Timestamp:

12/03/2016 05:07:03 AM (8 years ago)

Author:

pento

Message:

REST API: Capability check for editing a single term should use the singular form.

As an extra level of sanity checking, the term ID should be cast as an int in map_meta_cap().

Props johnbillion, nacin, dd32, pento.
See #35614.
Fixes #39012.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

@@ -289 +289 @@
 
     /**
-     * Checks if a request has access to read the specified term.
+     * Checks if a request has access to read or edit the specified term.
      *
      * @since 4.7.0
@@ -302 +302 @@
             return false;
         }
-        if ( 'edit' === $request['context'] && ! current_user_can( $tax_obj->cap->edit_terms ) ) {
-            return new WP_Error( 'rest_forbidden_context', __( 'Sorry, you are not allowed to edit terms in this taxonomy.' ), array( 'status' => rest_authorization_required_code() ) );
+        if ( 'edit' === $request['context'] && ! current_user_can( 'edit_term', (int) $request['id'] ) ) {
+            return new WP_Error( 'rest_forbidden_context', __( 'Sorry, you are not allowed to edit this term.' ), array( 'status' => rest_authorization_required_code() ) );
         }
         return true;