Changeset 39478 for trunk/tests/phpunit/tests/basic.php

Timestamp:

12/04/2016 05:29:26 PM (8 years ago)

Author:

nacin

Message:

Build/Test Tools: Specify exact node version in package.json.

Enforce it in the tests.

see #35105.

File:

• trunk/tests/phpunit/tests/basic.php (modified) (1 diff)

trunk/tests/phpunit/tests/basic.php

@@ -24 +24 @@
         }
         $this->assertEquals( $version, $package_json['version'], "package.json's version needs to be updated to $version." );
+        return $package_json;
     }
+
+    /**
+     * @depends test_package_json
+     */
+    function test_package_json_node_engine( $package_json ) {
+        $this->assertArrayHasKey( 'engines', $package_json );
+        $this->assertArrayHasKey( 'node', $package_json['engines'] );
+        $node = $package_json['engines']['node'];
+        $this->assertRegExp( '~^=?\d+\.\d+\.\d+$~', $node, "package.json's node version cannot be a range." );
+    }
 
     // two tests for a lame bug in PHPUnit that broke the $GLOBALS reference