Changeset 39480 for branches/4.7

Timestamp:

12/04/2016 05:37:38 PM (8 years ago)

Author:

nacin

Message:

Build/Test Tools: Specify exact node version in package.json.

Enforce it in the tests.

Merges [39478] to the 4.7 branch.

see #35105, #38657.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• package.json (modified) (1 diff)
• tests/phpunit/tests/basic.php (modified) (1 diff)

branches/4.7/package.json

@@ -6 +6 @@
     "type": "svn",
     "url": "https://develop.svn.wordpress.org/trunk"
+  },
+  "engines": {
+    "node": "6.9.1"
   },
   "author": "The WordPress Contributors",

branches/4.7/tests/phpunit/tests/basic.php

@@ -24 +24 @@
         }
         $this->assertEquals( $version, $package_json['version'], "package.json's version needs to be updated to $version." );
+        return $package_json;
     }
+
+    /**
+     * @depends test_package_json
+     */
+    function test_package_json_node_engine( $package_json ) {
+        $this->assertArrayHasKey( 'engines', $package_json );
+        $this->assertArrayHasKey( 'node', $package_json['engines'] );
+        $node = $package_json['engines']['node'];
+        $this->assertRegExp( '~^=?\d+\.\d+\.\d+$~', $node, "package.json's node version cannot be a range." );
+    }
 
     // two tests for a lame bug in PHPUnit that broke the $GLOBALS reference