Changeset 39506 for trunk/tests/phpunit/tests/customize/nav-menus.php

Timestamp:

12/05/2016 07:32:09 PM (8 years ago)

Author:

westonruter

Message:

Customize: Defer populating post_name for auto-draft posts in customized state until posts are published.

The ultimate post_name is stored in postmeta until the post is published. The get_page_by_path() function does not exclude auto-draft posts. Revert changes to wp_unique_post_slug() from [39411] which excluded auto-draft posts.

Props westonruter, dlh for testing, helen for testing.
See #38114, #38928.
Fixes #39078.

File:

• trunk/tests/phpunit/tests/customize/nav-menus.php (modified) (5 diffs)

trunk/tests/phpunit/tests/customize/nav-menus.php

@@ -550 +550 @@
         $this->assertInstanceOf( 'WP_Post', $r );
         $this->assertEquals( 'Hello World', $r->post_title );
-        $this->assertEquals( 'hello-world', $r->post_name );
+        $this->assertEquals( '', $r->post_name );
+        $this->assertEquals( 'hello-world', get_post_meta( $r->ID, '_customize_draft_post_name', true ) );
         $this->assertEquals( 'post', $r->post_type );
 
@@ -557 +558 @@
         $this->assertEquals( 'Hello World', $r->post_title );
         $this->assertEquals( 'post', $r->post_type );
-        $this->assertEquals( 'greetings-world', $r->post_name );
+        $this->assertEquals( '', $r->post_name );
+        $this->assertEquals( 'greetings-world', get_post_meta( $r->ID, '_customize_draft_post_name', true ) );
         $this->assertEquals( 'Hi World', $r->post_content );
     }
@@ -740 +742 @@
         do_action( 'customize_register', $this->wp_customize );
 
-        $post_ids = $this->factory()->post->create_many( 3, array(
-            'post_status' => 'auto-draft',
-            'post_type' => 'post',
-            'post_name' => 'auto-draft',
-        ) );
+        $post_ids = array();
+        for ( $i = 0; $i < 3; $i += 1 ) {
+            $r = $menus->insert_auto_draft_post( array(
+                'post_title' => 'Auto Draft ' . $i,
+                'post_type' => 'post',
+                'post_name' => 'auto-draft-' . $i,
+            ) );
+            $this->assertInstanceOf( 'WP_Post', $r );
+            $post_ids[] = $r->ID;
+        }
+
         $pre_published_post_id = $this->factory()->post->create( array( 'post_status' => 'publish' ) );
 
@@ -755 +763 @@
         foreach ( $post_ids as $post_id ) {
             $this->assertEquals( 'auto-draft', get_post_status( $post_id ) );
+            $this->assertEmpty( get_post( $post_id )->post_name );
+            $this->assertNotEmpty( get_post_meta( $post_id, '_customize_draft_post_name', true ) );
         }
 
@@ -762 +772 @@
         foreach ( $post_ids as $post_id ) {
             $this->assertEquals( 'publish', get_post_status( $post_id ) );
+            $this->assertRegExp( '/^auto-draft-\d+$/', get_post( $post_id )->post_name );
+            $this->assertEmpty( get_post_meta( $post_id, '_customize_draft_post_name', true ) );
         }