Changeset 39507 for branches/4.7/tests/phpunit/tests/customize/manager.php

Timestamp:

12/05/2016 07:38:16 PM (7 years ago)

Author:

westonruter

Message:

Customize: Defer populating post_name for auto-draft posts in customized state until posts are published.

The ultimate post_name is stored in postmeta until the post is published. The get_page_by_path() function does not exclude auto-draft posts. Revert changes to wp_unique_post_slug() from [39411] which excluded auto-draft posts.

Props westonruter, dlh for testing, helen for testing.
Merges [39506] onto 4.7 branch.
Fixes #39078 for 4.7.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/customize/manager.php (modified) (4 diffs)

branches/4.7/tests/phpunit/tests/customize/manager.php

@@ -454 +454 @@
             } else {
                 $this->assertEquals( 'auto-draft', $post->post_status );
+                $this->assertEmpty( $post->post_name );
             }
-            $posts_by_name[ $post->post_name ] = $post->ID;
+            $post_name = $post->post_name;
+            if ( empty( $post_name ) ) {
+                $post_name = get_post_meta( $post->ID, '_customize_draft_post_name', true );
+            }
+            $posts_by_name[ $post_name ] = $post->ID;
         }
         $this->assertEquals( array( 'waffles', 'canola', 'home', 'about', 'blog', 'custom' ), array_keys( $posts_by_name ) );
@@ -465 +470 @@
         $attachment_metadata = wp_get_attachment_metadata( $posts_by_name['waffles'] );
         $this->assertEquals( 'Waffles', get_post( $posts_by_name['waffles'] )->post_title );
+        $this->assertEquals( 'waffles', get_post_meta( $posts_by_name['waffles'], '_customize_draft_post_name', true ) );
         $this->assertArrayHasKey( 'file', $attachment_metadata );
         $this->assertContains( 'waffles', $attachment_metadata['file'] );
@@ -489 +495 @@
         $wp_customize->import_theme_starter_content();
         $changeset_data = $wp_customize->changeset_data();
-        $this->assertEqualSets( array_values( $posts_by_name ), $changeset_data['nav_menus_created_posts']['value'], 'Auto-drafts should not get re-created and amended with each import.' );
+        $this->assertEqualSets( array_values( $posts_by_name ), $changeset_data['nav_menus_created_posts']['value'] ); // Auto-drafts should not get re-created and amended with each import.
 
         // Test that saving non-starter content on top of the changeset clears the starter_content flag.
@@ -540 +546 @@
         $this->assertContains( 'waffles', get_header_image() );
         $this->assertContains( 'waffles', get_background_image() );
+        $this->assertEquals( 'waffles', get_post( $posts_by_name['waffles'] )->post_name );
+        $this->assertEmpty( get_post_meta( $posts_by_name['waffles'], '_customize_draft_post_name', true ) );
     }