Changeset 39507 for branches/4.7/tests/phpunit/tests/post/wpUniquePostSlug.php

Timestamp:

12/05/2016 07:38:16 PM (10 years ago)

Author:

westonruter

Message:

Customize: Defer populating post_name for auto-draft posts in customized state until posts are published.

The ultimate post_name is stored in postmeta until the post is published. The get_page_by_path() function does not exclude auto-draft posts. Revert changes to wp_unique_post_slug() from [39411] which excluded auto-draft posts.

Props westonruter, dlh for testing, helen for testing.
Merges [39506] onto 4.7 branch.
Fixes #39078 for 4.7.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/post/wpUniquePostSlug.php (modified) (1 diff)

branches/4.7/tests/phpunit/tests/post/wpUniquePostSlug.php

@@ -348 +348 @@
                 $this->assertSame( 'embed-2', $found );
         }
-
-        /**
-         * @ticket 38928
-         */
-        public function test_non_unique_slugs_for_existing_auto_draft_posts() {
-                $auto_draft_post_id = self::factory()->post->create( array(
-                        'post_type' => 'post',
-                        'post_name' => 'existing-post',
-                        'post_status' => 'auto-draft',
-                ) );
-                $auto_draft_page_id = self::factory()->post->create( array(
-                        'post_type' => 'page',
-                        'post_name' => 'existing-page',
-                        'post_status' => 'auto-draft',
-                ) );
-                $auto_draft_attachment_id = self::factory()->attachment->create_object( 'image.jpg', $auto_draft_page_id, array(
-                        'post_mime_type' => 'image/jpeg',
-                        'post_type' => 'attachment',
-                        'post_name' => 'existing-attachment',
-                        'post_status' => 'auto-draft',
-                ) );
-
-                $post_id = self::factory()->post->create( array( 'post_type' => 'post' ) );
-                $page_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
-                $attachment_id = self::factory()->attachment->create_object( 'image2.jpg', $page_id, array(
-                        'post_mime_type' => 'image/jpeg',
-                        'post_type' => 'attachment',
-                        'post_name' => 'existing-image',
-                ) );
-
-                $this->assertEquals( 'existing-post', wp_unique_post_slug( 'existing-post', $post_id, 'publish', get_post_type( $post_id ), 0 ) );
-                wp_publish_post( $auto_draft_post_id );
-                $this->assertEquals( 'existing-post-2', wp_unique_post_slug( 'existing-post', $post_id, 'publish', get_post_type( $post_id ), 0 ) );
-
-                $this->assertEquals( 'existing-page', wp_unique_post_slug( 'existing-page', $page_id, 'publish', get_post_type( $page_id ), 0 ) );
-                wp_publish_post( $auto_draft_page_id );
-                $this->assertEquals( 'existing-page-2', wp_unique_post_slug( 'existing-page', $page_id, 'publish', get_post_type( $page_id ), 0 ) );
-
-                $this->assertEquals( 'existing-attachment', wp_unique_post_slug( 'existing-attachment', $attachment_id, 'publish', get_post_type( $attachment_id ), 0 ) );
-                wp_publish_post( $auto_draft_attachment_id );
-                $this->assertEquals( 'existing-attachment-2', wp_unique_post_slug( 'existing-attachment', $attachment_id, 'publish', get_post_type( $attachment_id ), 0 ) );
-        }
 }