Changeset 39510 for trunk

Timestamp:

12/06/2016 02:50:13 AM (8 years ago)

Author:

westonruter

Message:

Customize: Prevent infinite full refresh from occurring when selective refresh falls back for a nav menu that has items excluded from rendering via filtering.

See #37032.
Fixes #38612.

File:

• trunk/src/wp-includes/js/customize-preview-nav-menus.js (modified) (2 diffs)

trunk/src/wp-includes/js/customize-preview-nav-menus.js

@@ -16 +16 @@
      */
     self.init = function() {
-        var self = this;
+        var self = this, synced = false;
+
+        /*
+         * Keep track of whether we synced to determine whether or not bindSettingListener
+         * should also initially fire the listener. This initial firing needs to wait until
+         * after all of the settings have been synced from the pane in order to prevent
+         * an infinite selective fallback-refresh. Note that this sync handler will be
+         * added after the sync handler in customize-preview.js, so it will be triggered
+         * after all of the settings are added.
+         */
+        api.preview.bind( 'sync', function() {
+            synced = true;
+        } );
 
         if ( api.selectiveRefresh ) {
@@ -33 +45 @@
                  */
                 if ( setting.get() && ! setting.get()._invalid ) {
-                    self.bindSettingListener( setting, { fire: true } );
+                    self.bindSettingListener( setting, { fire: synced } );
                 }
             } );