Changeset 39539

Timestamp:

12/07/2016 10:08:52 PM (8 years ago)

Author:

flixos90

Message:

Multisite: Remove redundant is_super_admin() when checking for edit_others_posts.

The super admin on multisite as well as the administrator on non-multisite both have this capability already. For custom post types using different capabilities this change ensures that only users with that capability have permissions.

Fixes #39059. See #37616.

Location:

trunk/src/wp-admin

Files:

• edit-form-advanced.php (modified) (1 diff)
• includes/class-wp-posts-list-table.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-advanced.php

@@ -309 +309 @@
     add_meta_box('slugdiv', __('Slug'), 'post_slug_meta_box', null, 'normal', 'core');
 
-if ( post_type_supports($post_type, 'author') ) {
-    if ( is_super_admin() || current_user_can( $post_type_object->cap->edit_others_posts ) )
-        add_meta_box('authordiv', __('Author'), 'post_author_meta_box', null, 'normal', 'core');
+if ( post_type_supports( $post_type, 'author' ) && current_user_can( $post_type_object->cap->edit_others_posts ) ) {
+    add_meta_box( 'authordiv', __( 'Author' ), 'post_author_meta_box', null, 'normal', 'core' );
 }
 

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1421 +1421 @@
             $authors_dropdown = '';
 
-            if ( is_super_admin() || current_user_can( $post_type_object->cap->edit_others_posts ) ) :
+            if ( current_user_can( $post_type_object->cap->edit_others_posts ) ) :
                 $users_opt = array(
                     'hide_if_only_one_author' => false,