WordPress.org

Make WordPress Core


Ignore:
Timestamp:
12/10/2016 06:45:00 AM (4 years ago)
Author:
westonruter
Message:

Customize: Prevent single quotes (apostrophes) in custom_css values from unexpectedly causing false positives for unbalanced character validation errors.

See #39218, #35395.
Fixes #39198.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/customize/custom-css-setting.php

    r39477 r39559  
    365365        $this->assertTrue( array_key_exists( 'unequal_double_quotes', $result->errors ) );
    366366
    367         // Check for Imbalanced Single Quotes.
    368         $imbalanced_single_quotes = $basic_css . " div.background-image { background-image: url( 'image.jpg ); } ";
    369         $result = $this->setting->validate( $imbalanced_single_quotes );
    370         $this->assertTrue( array_key_exists( 'unequal_single_quotes', $result->errors ) );
    371 
    372367        // Check for Unclosed Parentheses.
    373368        $unclosed_parentheses = $basic_css . ' div.background-image { background-image: url( "image.jpg" ; } ';
Note: See TracChangeset for help on using the changeset viewer.