Changeset 39563 for trunk/tests/phpunit/tests/rest-api/rest-request.php

Timestamp:

12/11/2016 09:25:40 PM (8 years ago)

Author:

rachelbaker

Message:

REST API: Allow schema sanitization_callback to be set to null to bypass fallback sanitization functions.

The logic in WP_REST_Request->sanitize_params() added in [39091] did not account for null or false being the sanitization_callback preventing overriding rest_parse_request_arg(). This fixes that oversight, allowing the built in sanitization function to be bypassed. See #38593.

Props kkoppenhaver, rachelbaker, jnylen0.
Fixes #39042.

File:

• trunk/tests/phpunit/tests/rest-api/rest-request.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-request.php

@@ -341 +341 @@
         $this->assertWPError( $valid );
         $this->assertEquals( 'rest_invalid_param', $valid->get_error_code() );
+    }
+
+    public function test_sanitize_params_with_null_callback() {
+        $this->request->set_url_params( array(
+            'some_email' => '',
+        ) );
+
+        $this->request->set_attributes( array(
+            'args' => array(
+                'some_email' => array(
+                    'type'              => 'string',
+                    'format'            => 'email',
+                    'sanitize_callback' => null,
+                ),
+            ),
+        ) );
+
+        $this->assertTrue( $this->request->sanitize_params() );
+    }
+
+    public function test_sanitize_params_with_false_callback() {
+        $this->request->set_url_params( array(
+            'some_uri'   => 1.23422,
+        ) );
+
+        $this->request->set_attributes( array(
+            'args' => array(
+                'some_uri' => array(
+                    'type'              => 'string',
+                    'format'            => 'uri',
+                    'sanitize_callback' => false,
+                ),
+            ),
+        ) );
+
+        $this->assertTrue( $this->request->sanitize_params() );
     }