Changeset 39564 for trunk/src/wp-includes/option.php

Timestamp:

12/11/2016 09:42:12 PM (8 years ago)

Author:

peterwilsoncc

Message:

Options: Prevent unnecessary SQL updates by update_option.

Previously an option containing an object would trigger an SQL UPDATE on all calls to update_option, even if the old and new values were identical. This was due to the old and new values having differing resource IDs.

This change compares the old and new values as serialized data to remove the resource ID from the comparison.

Props salcode, bradyvercher, peterwilsoncc.
Fixes #38903.

File:

• trunk/src/wp-includes/option.php (modified) (1 diff)

trunk/src/wp-includes/option.php

@@ -296 +296 @@
     $value = apply_filters( 'pre_update_option', $value, $option, $old_value );
 
-    // If the new and old values are the same, no need to update.
-    if ( $value === $old_value )
+    /*
+     * If the new and old values are the same, no need to update.
+     *
+     * Unserialized values will be adequate in most cases. If the unserialized
+     * data differs, the (maybe) serialized data is checked to avoid
+     * unnecessary database calls for otherwise identical object instances.
+     *
+     * See https://core.trac.wordpress.org/ticket/38903
+     */
+    if ( $value === $old_value || maybe_serialize( $value ) === maybe_serialize( $old_value ) ) {
         return false;
+    }
 
     /** This filter is documented in wp-includes/option.php */