Changeset 39566 for branches/4.7/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

Timestamp:

12/12/2016 01:39:13 AM (10 years ago)

Author:

dd32

Message:

REST API: Treat any falsy value as false in 'rest_allow_anonymous_comments'.

Extend the check in 'rest_allow_anonymous_comments' to accept any falsy value (previously this was an explicit check for false).

One possible failure case is that a plugin developer forgets to include a return value for some code path in their callback for this filter, leading to a value of null which is currently treated like true.

Props joehoyle, jnylen0.
Merges [39487] to the 4.7 branch.
Fixes #39010.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)

branches/4.7/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -393 +393 @@
                          */
                         $allow_anonymous = apply_filters( 'rest_allow_anonymous_comments', false, $request );
-                        if ( false === $allow_anonymous ) {
+                        if ( ! $allow_anonymous ) {
                                 return new WP_Error( 'rest_comment_login_required', __( 'Sorry, you must be logged in to comment.' ), array( 'status' => 401 ) );
                         }