Changeset 39575

Timestamp:

12/12/2016 02:24:19 AM (8 years ago)

Author:

dd32

Message:

Customize: Deprecate page_home nav menu item starter content in favor of home_link; replace usage in Twenty Seventeen.

Props celloexpressions, westonruter.
See #38615, #38114, [38991].
Merges [39561] to the 4.7 branch.
Fixes #39104.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentyseventeen/functions.php (modified) (1 diff)
• src/wp-includes/theme.php (modified) (1 diff)
• tests/phpunit/tests/customize/manager.php (modified) (2 diffs)

branches/4.7/src/wp-content/themes/twentyseventeen/functions.php

@@ -170 +170 @@
                 'name' => __( 'Top Menu', 'twentyseventeen' ),
                 'items' => array(
-                    'page_home',
+                    'link_home',
                     'page_about',
                     'page_blog',

branches/4.7/src/wp-includes/theme.php

@@ -1966 +1966 @@
         ),
         'nav_menus' => array(
-            'page_home' => array(
+            'link_home' => array(
+                'type' => 'custom',
+                'title' => _x( 'Home', 'Theme starter content' ),
+                'url' => home_url(),
+            ),
+            'page_home' => array( // Deprecated in favor of home_link.
                 'type' => 'post_type',
                 'object' => 'page',

branches/4.7/tests/phpunit/tests/customize/manager.php

@@ -351 +351 @@
                     'name'  => 'Menu Name',
                     'items' => array(
-                        'page_home',
+                        'link_home',
                         'page_about',
                         'page_blog',
@@ -479 +479 @@
 
         $this->assertEquals( -1, $changeset_values['nav_menu_locations[top]'] );
-        $this->assertEquals( $posts_by_name['home'], $changeset_values['nav_menu_item[-1]']['object_id'] );
+        $this->assertEquals( 0, $changeset_values['nav_menu_item[-1]']['object_id'] );
+        $this->assertEquals( 'custom', $changeset_values['nav_menu_item[-1]']['type'] );
+        $this->assertEquals( home_url(), $changeset_values['nav_menu_item[-1]']['url'] );
 
         $this->assertEmpty( $wp_customize->changeset_data() );