Changeset 39594 for trunk/tests/phpunit/tests/rest-api/rest-request.php

Timestamp:

12/13/2016 03:33:14 AM (10 years ago)

Author:

jnylen0

Message:

REST API: Do not error on empty JSON body

It's fairly common for clients to send Content-Type: application/json with an
empty body. While technically not valid JSON, we've historically supported
this behaviour, so it shouldn't cause an error.

Props JPry.
Fixes #39150.

File:

• trunk/tests/phpunit/tests/rest-api/rest-request.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-request.php

@@ -11 +11 @@
  */
 class Tests_REST_Request extends WP_UnitTestCase {
+        public $request;
+
         public function setUp() {
                 parent::setUp();
@@ -449 +451 @@
                 $data = $valid->get_error_data();
                 $this->assertEquals( JSON_ERROR_SYNTAX, $data['json_error_code'] );
+        }
+
+
+        public function test_has_valid_params_empty_json_no_error() {
+                if ( version_compare( PHP_VERSION, '5.3', '<' ) ) {
+                        return $this->markTestSkipped( 'JSON validation is only available for PHP 5.3+' );
+                }
+
+                $this->request->set_header( 'Content-Type', 'application/json' );
+                $this->request->set_body( '' );
+
+                $valid = $this->request->has_valid_params();
+                $this->assertNotWPError( $valid );
         }