Changeset 39597 for trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Timestamp:

12/13/2016 01:52:49 PM (8 years ago)

Author:

jnylen0

Message:

REST API: Allow sending an empty or no-op comment update.

In general, updates that don't actually change anything should succeed.
[39371] added tests for other object types, and this commit fixes empty updates
for comments and adds the missing test.

Fixes #38700.

File:

• trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -1962 +1962 @@
     }
 
+    public function test_update_item_no_change() {
+        $comment = get_comment( self::$approved_id );
+
+        wp_set_current_user( self::$admin_id );
+        $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/comments/%d', self::$approved_id ) );
+        $request->set_param( 'post', $comment->comment_post_ID );
+
+        // Run twice to make sure that the update still succeeds even if no DB
+        // rows are updated.
+        $response = $this->server->dispatch( $request );
+        $this->assertEquals( 200, $response->get_status() );
+
+        $response = $this->server->dispatch( $request );
+        $this->assertEquals( 200, $response->get_status() );
+    }
+
     public function test_update_comment_status() {
         wp_set_current_user( self::$admin_id );
@@ -2205 +2221 @@
         $response = $this->server->dispatch( $request );
         $this->assertErrorResponse( 'rest_comment_invalid_id', $response, 404 );
+    }
+
+    public function test_update_comment_invalid_post_id() {
+        wp_set_current_user( self::$admin_id );
+
+        $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/comments/%d', self::$approved_id ) );
+        $request->set_param( 'post', REST_TESTS_IMPOSSIBLY_HIGH_NUMBER );
+
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_comment_invalid_post_id', $response, 403 );
     }