Changeset 39599

Timestamp:

12/14/2016 03:42:58 AM (8 years ago)

Author:

johnbillion

Message:

Posts, Post Types: Ensure is_page_template() can only return true when viewing a singular post query.

Props natereist, dlh
Fixes #39211

Location:

trunk

Files:

• src/wp-includes/post-template.php (modified) (1 diff)
• tests/phpunit/tests/query/conditionals.php (modified) (1 diff)

trunk/src/wp-includes/post-template.php

@@ -1632 +1632 @@
  */
 function is_page_template( $template = '' ) {
+    if ( ! is_singular() ) {
+        return false;
+    }
+
     $page_template = get_page_template_slug( get_queried_object_id() );
 

trunk/tests/phpunit/tests/query/conditionals.php

@@ -1075 +1075 @@
 
     /**
+     * @ticket 39211
+     */
+    function test_is_page_template_not_singular() {
+        global $wpdb;
+
+        // We need a non-post that shares an ID with a post assigned a template.
+        $user_id = self::factory()->user->create();
+        if ( ! get_post( $user_id ) ) {
+            $post_id = self::factory()->post->create( array( 'post_type' => 'post' ) );
+            $wpdb->update( $wpdb->posts, array( 'ID' => $user_id ), array( 'ID' => $post_id ), array( '%d' ) );
+        }
+
+        update_post_meta( $user_id, '_wp_page_template', 'example.php' );
+
+        // Verify that the post correctly reports having a template.
+        $this->go_to( get_post_permalink( $user_id ) );
+        $this->assertInstanceOf( 'WP_Post', get_queried_object() );
+        $this->assertTrue( is_page_template( 'example.php' ) );
+
+        // Verify that the non-post with a matching ID does not report having a template.
+        $this->go_to( get_author_posts_url( $user_id ) );
+        $this->assertInstanceOf( 'WP_User', get_queried_object() );
+        $this->assertFalse( is_page_template( 'example.php' ) );
+    }
+
+    /**
      * @ticket 35902
      */