Changeset 39604 for branches/4.7

Timestamp:

12/15/2016 01:01:26 PM (8 years ago)

Author:

adamsilverstein

Message:

WP-API: JavaScript client - fix setup of models used by wp.api.collections objects.

Correct setup for the model attribute of wp.api.collections objects. Set the collection model as a function that returns a new model of the underlying type, instead of setting it as the model prototype. Fixes an issue where models for fetched collections weren't set up properly and didn't have the expected mixin methods such as getCategories available.

Props jesseenterprises.
Merges [39603] to the 4.7 branch.
Fixes #39070.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-includes/js/wp-api.js (modified) (2 diffs)

branches/4.7/src/wp-includes/js/wp-api.js

@@ -1235 +1235 @@
 
                         // Specify the model that this collection contains.
-                        model: loadingObjects.models[ modelClassName ],
+                        model: function( attrs, options ) {
+                            return new loadingObjects.models[ modelClassName ]( attrs, options );
+                        },
 
                         // Include a reference to the original class name.
@@ -1258 +1260 @@
 
                         // Specify the model that this collection contains.
-                        model: loadingObjects.models[ modelClassName ],
+                        model: function( attrs, options ) {
+                            return new loadingObjects.models[ modelClassName ]( attrs, options );
+                        },
 
                         // Include a reference to the original class name.