Changeset 39613

Timestamp:

12/16/2016 06:38:10 AM (8 years ago)

Author:

dd32

Message:

Feeds: Do not translate the lastBuildDate field in RSS feeds.

Props stevenkword, dd32.
Fixes #39141

Location:

trunk

Files:

• src/wp-includes/feed-atom-comments.php (modified) (1 diff)
• src/wp-includes/feed-atom.php (modified) (1 diff)
• src/wp-includes/feed-rss2-comments.php (modified) (1 diff)
• src/wp-includes/feed-rss2.php (modified) (1 diff)
• tests/phpunit/tests/feed/rss2.php (modified) (1 diff)

trunk/src/wp-includes/feed-atom-comments.php

@@ -44 +44 @@
     <updated><?php
         $date = get_lastcommentmodified( 'GMT' );
-        echo $date ? mysql2date( 'Y-m-d\TH:i:s\Z', $date ) : date( 'Y-m-d\TH:i:s\Z' );
+        echo $date ? mysql2date( 'Y-m-d\TH:i:s\Z', $date, false ) : date( 'Y-m-d\TH:i:s\Z' );
     ?></updated>
 

trunk/src/wp-includes/feed-atom.php

@@ -33 +33 @@
     <updated><?php
         $date = get_lastpostmodified( 'GMT' );
-        echo $date ? mysql2date( 'Y-m-d\TH:i:s\Z', $date ) : date( 'Y-m-d\TH:i:s\Z' );
+        echo $date ? mysql2date( 'Y-m-d\TH:i:s\Z', $date, false ) : date( 'Y-m-d\TH:i:s\Z' );
     ?></updated>
 

trunk/src/wp-includes/feed-rss2-comments.php

@@ -50 +50 @@
     <lastBuildDate><?php
         $date = get_lastcommentmodified( 'GMT' );
-        echo $date ? mysql2date( 'r', $date ) : date( 'r' );
+        echo $date ? mysql2date( 'r', $date, false ) : date( 'r' );
     ?></lastBuildDate>
     <sy:updatePeriod><?php

trunk/src/wp-includes/feed-rss2.php

@@ -45 +45 @@
     <lastBuildDate><?php
         $date = get_lastpostmodified( 'GMT' );
-        echo $date ? mysql2date( 'D, d M Y H:i:s +0000', $date ) : date( 'D, d M Y H:i:s +0000' );
+        echo $date ? mysql2date( 'D, d M Y H:i:s +0000', $date, false ) : date( 'D, d M Y H:i:s +0000' );
     ?></lastBuildDate>
     <language><?php bloginfo_rss( 'language' ); ?></language>

trunk/tests/phpunit/tests/feed/rss2.php

@@ -137 +137 @@
 
     /**
+     * Test that translated feeds have a valid listed date.
+     * @group 39141
+     */
+    function test_channel_pubdate_element_translated() {
+        $original_locale = $GLOBALS['wp_locale'];
+        /* @var WP_Locale $locale */
+        $locale = clone $GLOBALS['wp_locale'];
+
+        $locale->weekday[2] = 'Tuesday_Translated';
+        $locale->weekday_abbrev[ 'Tuesday_Translated' ] = 'Tue_Translated';
+
+        $GLOBALS['wp_locale'] = $locale;
+
+        $this->go_to( '/?feed=rss2' );
+        $feed = $this->do_rss2();
+
+        // Restore original locale.
+        $GLOBALS['wp_locale'] = $original_locale;
+
+        $xml = xml_to_array( $feed );
+
+        // Verify the date is untranslated.
+        $pubdate = xml_find( $xml, 'rss', 'channel', 'lastBuildDate' );
+        $this->assertNotContains( 'Tue_Translated', $pubdate[0]['content'] );
+    }
+
+    /**
      * @ticket UT32
      */