Changeset 39623 for trunk

Timestamp:

12/20/2016 10:16:35 PM (8 years ago)

Author:

davidakennedy

Message:

Twenty Seventeen: Ensure functions in customize-controls.js don't count on Customizer sections always being present

Before, the code assumed the theme_options section is always present, but it can be removed by plugins. This way, if it is, no JavaScript errors occur.

Props westonruter.

Fixes #39335.

File:

• trunk/src/wp-content/themes/twentyseventeen/assets/js/customize-controls.js (modified) (1 diff)

trunk/src/wp-content/themes/twentyseventeen/assets/js/customize-controls.js

@@ -26 +26 @@
 
         // Detect when the front page sections section is expanded (or closed) so we can adjust the preview accordingly.
-        wp.customize.section( 'theme_options' ).expanded.bind( function( isExpanding ) {
+        wp.customize.section( 'theme_options', function( section ) {
+            section.expanded.bind( function( isExpanding ) {
 
-            // Value of isExpanding will = true if you're entering the section, false if you're leaving it.
-            wp.customize.previewer.send( 'section-highlight', { expanded: isExpanding });
-        });
+                // Value of isExpanding will = true if you're entering the section, false if you're leaving it.
+                wp.customize.previewer.send( 'section-highlight', { expanded: isExpanding });
+            } );
+        } );
     });
 })( jQuery );