Changeset 39628 for branches/4.7/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

Timestamp:

12/21/2016 05:12:06 AM (7 years ago)

Author:

pento

Message:

REST API: Allow sending an empty or no-op comment update.

In general, updates that don't actually change anything should succeed. [39371] added tests for other object types, and this commit fixes empty updates for comments and adds the missing test.

Merges [39597] to the 4.7 branch.

Props jnylen0.
Fixes #38700.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (2 diffs)

branches/4.7/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -665 +665 @@
         }
 
+        if ( ! empty( $prepared_args['comment_post_ID'] ) ) {
+            $post = get_post( $prepared_args['comment_post_ID'] );
+            if ( empty( $post ) ) {
+                return new WP_Error( 'rest_comment_invalid_post_id', __( 'Invalid post ID.' ), array( 'status' => 403 ) );
+            }
+        }
+
         if ( empty( $prepared_args ) && isset( $request['status'] ) ) {
             // Only the comment status is being changed.
@@ -691 +698 @@
             $updated = wp_update_comment( wp_slash( (array) $prepared_args ) );
 
-            if ( 0 === $updated ) {
+            if ( false === $updated ) {
                 return new WP_Error( 'rest_comment_failed_edit', __( 'Updating comment failed.' ), array( 'status' => 500 ) );
             }