Changeset 39662 for trunk

Timestamp:

01/02/2017 07:38:07 PM (10 years ago)

Author:

boonebgorges

Message:

Don't double-escape terms payload in WP_Tax_Query::transform_query().

terms values are passed through sanitize_term_field() with the 'db'
flag, which add slashes. Because terms are subsequently run through
esc_sql(), these slashes must be removed. See [36348], which added
a similar step to sanitization in get_terms().

Props bcworkz.
Fixes #39315.

Location:

trunk

Files:

• src/wp-includes/class-wp-tax-query.php (modified) (1 diff)
• tests/phpunit/tests/query/taxQuery.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-tax-query.php

@@ -624 +624 @@
                                          * context is 'db'.
                                          */
-                                        $term = "'" . esc_sql( sanitize_term_field( $query['field'], $term, 0, $query['taxonomy'], 'db' ) ) . "'";
+                                        $clean_term = sanitize_term_field( $query['field'], $term, 0, $query['taxonomy'], 'db' );
+
+                                        // Match sanitization in wp_insert_term().
+                                        $clean_term = wp_unslash( $clean_term );
+
+                                        $term = "'" . esc_sql( $clean_term ) . "'";
                                 }
 

trunk/tests/phpunit/tests/query/taxQuery.php

@@ -1381 +1381 @@
                 _unregister_taxonomy( 'foo' );
         }
+
+        /**
+         * @ticket 39315
+         */
+        public function test_tax_terms_should_not_be_double_escaped() {
+                $name = "Don't worry be happy";
+
+                register_taxonomy( 'wptests_tax', 'post' );
+                $t = self::factory()->term->create( array(
+                        'taxonomy' => 'wptests_tax',
+                        'name' => $name,
+                ) );
+
+                $p = self::factory()->post->create();
+                wp_set_object_terms( $p, array( $t ), 'wptests_tax' );
+
+                $q = new WP_Query( array(
+                        'fields' => 'ids',
+                        'tax_query' => array(
+                                array(
+                                        'taxonomy' => 'wptests_tax',
+                                        'field' => 'name',
+                                        'terms' => $name,
+                                ),
+                        ),
+                ) );
+
+                $this->assertEqualSets( array( $p ), $q->posts );
+        }
 }