Changeset 39715

Timestamp:

01/05/2017 04:18:19 PM (10 years ago)

Author:

joemcgill

Message:

Media: Improved media titles when created from filename.

Preserves spaces and generally creates more accurate, cleaner titles from filenames of uploaded media.

Merge of [38615] to the 4.1 branch.

Fixes #37989.

Location:

branches/4.1

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/media.php (modified) (1 diff)
• tests/phpunit/tests/media.php (modified) (1 diff)

branches/4.1/src/wp-admin/includes/media.php

@@ -280 +280 @@
         $type = $file['type'];
         $file = $file['file'];
-        $title = sanitize_title( $name );
+        $title = sanitize_text_field( $name );
         $content = '';
 

branches/4.1/tests/phpunit/tests/media.php

@@ -469 +469 @@
 
         /**
+         * @ticket 37989
+         */
+        public function test_media_handle_upload_expected_titles() {
+                $test_file = DIR_TESTDATA . '/images/test-image.jpg';
+
+                // Make a copy of this file as it gets moved during the file upload
+                $tmp_name = wp_tempnam( $test_file );
+
+                copy( $test_file, $tmp_name );
+
+                $_FILES['upload'] = array(
+                        'tmp_name' => $tmp_name,
+                        'name'     => 'This is a test.jpg',
+                        'type'     => 'image/jpeg',
+                        'error'    => 0,
+                        'size'     => filesize( $test_file ),
+                );
+
+                $post_id = media_handle_upload( 'upload', 0, array(), array( 'action' => 'test_upload_titles', 'test_form' => false ) );
+
+                unset( $_FILES['upload'] );
+
+                $post = get_post( $post_id );
+
+                // Clean up.
+                wp_delete_attachment( $post_id );
+
+                $this->assertEquals( 'This is a test', $post->post_title );
+        }
+
+        /**
          * @ticket 33016
          */