Changeset 39906

Timestamp:

01/15/2017 06:50:00 AM (8 years ago)

Author:

SergeyBiryukov

Message:

Themes: Add a unit test for get_theme_feature_list() to make sure that the list of theme features pulled from the WordPress.org API returns the expected data structure.

Props iandunn.
Fixes #28121.

Location:

trunk/tests/phpunit

Files:

• includes/testcase.php (modified) (1 diff)
• tests/admin/includesTheme.php (modified) (1 diff)

trunk/tests/phpunit/includes/testcase.php

@@ -438 +438 @@
         ksort( $actual );
         $this->assertEquals( $expected, $actual );
+    }
+
+    /**
+     * Asserts that the given variable is a multidimensional array, and that all arrays are non-empty.
+     *
+     * @param array $array
+     */
+    function assertNonEmptyMultidimensionalArray( $array ) {
+        $this->assertTrue( is_array( $array ) );
+        $this->assertNotEmpty( $array );
+
+        foreach( $array as $sub_array ) {
+            $this->assertTrue( is_array( $sub_array ) );
+            $this->assertNotEmpty( $sub_array );
+        }
     }
 

trunk/tests/phpunit/tests/admin/includesTheme.php

@@ -137 +137 @@
         $this->assertEquals( array(), get_page_templates( null, 'bar' ) );
     }
+
+    /**
+     * Test that the list of theme features pulled from the WordPress.org API returns the expected data structure.
+     *
+     * Differences in the structure can also trigger failure by causing PHP notices/warnings.
+     *
+     * @group external-http
+     * @ticket 28121
+     */
+    function test_get_theme_featured_list_api() {
+        wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
+        $featured_list_api = get_theme_feature_list( true );
+        $this->assertNonEmptyMultidimensionalArray( $featured_list_api );
+    }
+
+    /**
+     * Test that the list of theme features hardcoded into Core returns the expected data structure.
+     *
+     * Differences in the structure can also trigger failure by causing PHP notices/warnings.
+     *
+     * @group external-http
+     * @ticket 28121
+     */
+    function test_get_theme_featured_list_hardcoded() {
+        $featured_list_hardcoded = get_theme_feature_list( false );
+        $this->assertNonEmptyMultidimensionalArray( $featured_list_hardcoded );
+    }
 }