Changeset 39915

Timestamp:

01/16/2017 11:23:06 PM (8 years ago)

Author:

pento

Message:

User Query: Cast $user_total as an int.

The $user_total member of WP_User_Query, and corresponding get_total() method, have always been documented as returning an int. $user_total, however, is populated by $wpdb->get_var(), which returns
a string (containing an integer value). Casting the return value from get_var() as an int rectifies this discrepency.

Props runciters.
Fixes #39297.

Location:

trunk

Files:

• src/wp-includes/class-wp-user-query.php (modified) (1 diff)
• tests/phpunit/tests/user/query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-user-query.php

@@ -613 +613 @@
          */
         if ( isset( $qv['count_total'] ) && $qv['count_total'] )
-            $this->total_users = $wpdb->get_var( apply_filters( 'found_users_query', 'SELECT FOUND_ROWS()' ) );
+            $this->total_users = (int) $wpdb->get_var( apply_filters( 'found_users_query', 'SELECT FOUND_ROWS()' ) );
 
         if ( !$this->results )

trunk/tests/phpunit/tests/user/query.php

@@ -123 +123 @@
             $this->assertInstanceOf( 'WP_User', $user );
         }
+    }
+
+    /**
+     * @ticket 39297
+     */
+    public function test_get_total_is_int() {
+        $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id() ) );
+        $total_users = $users->get_total();
+
+        $this->assertSame( 13, $total_users );
     }