Changeset 39967 for trunk

Timestamp:

01/26/2017 01:52:06 PM (8 years ago)

Author:

joehoyle

Message:

REST API: Return an error if the page number is out of bounds.

Return an error from the REST API if a page number larger than the total pages count is requested.

Props morganestes.
Fixes #39061.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -328 +328 @@
 
         $max_pages = ceil( $total_posts / (int) $posts_query->query_vars['posts_per_page'] );
+
+        if ( $page > $max_pages && $total_posts > 0 ) {
+            return new WP_Error( 'rest_post_invalid_page_number', __( 'The page number requested is larger than the number of pages available.' ), array( 'status' => 400 ) );
+        }
+
         $response  = rest_ensure_response( $posts );
 

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -826 +826 @@
         $response = $this->server->dispatch( $request );
         $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+    }
+
+    /**
+     * @ticket 39061
+     */
+    public function test_get_items_invalid_max_pages() {
+        // Out of bounds
+        $request = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+        $request->set_param( 'page', REST_TESTS_IMPOSSIBLY_HIGH_NUMBER );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_post_invalid_page_number', $response, 400 );
     }