Changeset 39991 for trunk

Timestamp:

01/26/2017 03:15:07 PM (8 years ago)

Author:

joehoyle

Message:

REST API: Fix unit tests for posts out of bounds errors

Previously we were assuming pagination headers would be sent when the request for posts is out of bounds. Instead presume it will return an error.

See #39061.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -544 +544 @@
         $this->assertCount( 2, $response->get_data() );
         // 'offset' takes priority over 'page'
-        $request->set_param( 'page', 3 );
+        $request->set_param( 'page', 2 );
         $response = $this->server->dispatch( $request );
         $this->assertCount( 2, $response->get_data() );
@@ -772 +772 @@
         $this->assertContains( '<' . $prev_link . '>; rel="prev"', $headers['Link'] );
         $this->assertFalse( stripos( $headers['Link'], 'rel="next"' ) );
+
         // Out of bounds
         $request = new WP_REST_Request( 'GET', '/wp/v2/posts' );
@@ -777 +778 @@
         $response = $this->server->dispatch( $request );
         $headers = $response->get_headers();
-        $this->assertEquals( 51, $headers['X-WP-Total'] );
-        $this->assertEquals( 6, $headers['X-WP-TotalPages'] );
-        $prev_link = add_query_arg( array(
-            'page'    => 6,
-            ), rest_url( '/wp/v2/posts' ) );
-        $this->assertContains( '<' . $prev_link . '>; rel="prev"', $headers['Link'] );
-        $this->assertFalse( stripos( $headers['Link'], 'rel="next"' ) );
+        $this->assertErrorResponse( 'rest_post_invalid_page_number', $response, 400 );
 
         // With query params.