Changeset 39993 for branches/4.7/tests/phpunit/tests/comment/wpComment.php

Timestamp:

01/26/2017 04:56:21 PM (8 years ago)

Author:

boonebgorges

Message:

Revert to pre-4.7 behavior for fetching object instances by id.

This changeset reverts [38381], which caused inconsistencies in the way the
REST API fetches posts and other objects.

Merge of [39992] to the 4.7 branch.

See #38792, #37738.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/comment/wpComment.php (modified) (2 diffs)

branches/4.7/tests/phpunit/tests/comment/wpComment.php

@@ -53 +53 @@
      * @ticket 37738
      */
-    public function test_get_instance_should_fail_for_bool() {
-        $found = WP_Comment::get_instance( true );
-
-        $this->assertFalse( $found );
-    }
-
-    /**
-     * @ticket 37738
-     */
     public function test_get_instance_should_succeed_for_float_that_is_equal_to_post_id() {
         $found = WP_Comment::get_instance( 1.0 );
@@ -67 +58 @@
         $this->assertEquals( 1, $found->comment_ID );
     }
-
-    /**
-     * @ticket 37738
-     */
-    public function test_get_instance_should_fail_for_float() {
-        $found = WP_Comment::get_instance( 1.6 );
-
-        $this->assertFalse( $found );
-    }
-
-    /**
-     * @ticket 37738
-     */
-    public function test_get_instance_should_fail_for_array() {
-        $found = WP_Comment::get_instance( array( 1 ) );
-
-        $this->assertFalse( $found );
-    }
-
-    /**
-     * @ticket 37738
-     */
-    public function test_get_instance_should_fail_for_class() {
-        $class = new stdClass();
-        $found = WP_Comment::get_instance( $class );
-
-        $this->assertFalse( $found );
-    }
 }