Changeset 40035

Timestamp:

01/31/2017 09:58:49 AM (10 years ago)

Author:

SergeyBiryukov

Message:

Update/Install: Give context to "Deleted! string to allow for differentiation between theme and plugin translations.

Props swissspidy.
See #39747. See #37290.

Location:

trunk

Files:

• src/wp-admin/js/updates.js (modified) (2 diffs)
• src/wp-includes/script-loader.php (modified) (1 diff)
• tests/qunit/fixtures/updates.js (modified) (1 diff)

trunk/src/wp-admin/js/updates.js

@@ -842 +842 @@
                 } );
 
-                wp.a11y.speak( wp.updates.l10n.deleted, 'polite' );
+                wp.a11y.speak( wp.updates.l10n.pluginDeleted, 'polite' );
 
                 $document.trigger( 'wp-plugin-delete-success', response );
@@ -1274 +1274 @@
                 }
 
-                wp.a11y.speak( wp.updates.l10n.deleted, 'polite' );
+                wp.a11y.speak( wp.updates.l10n.themeDeleted, 'polite' );
 
                 $document.trigger( 'wp-theme-delete-success', response );

trunk/src/wp-includes/script-loader.php

@@ -694 +694 @@
                                 /* translators: %s: Error string for a failed deletion */
                                 'deleteFailed'               => __( 'Deletion failed: %s' ),
-                                'deleted'                    => __( 'Deleted!' ),
+                                'pluginDeleted'              => _x( 'Deleted!', 'plugin' ),
+                                'themeDeleted'               => _x( 'Deleted!', 'theme' ),
                                 'livePreview'                => __( 'Live Preview' ),
                                 'activatePlugin'             => is_network_admin() ? __( 'Network Activate' ) : __( 'Activate' ),

trunk/tests/qunit/fixtures/updates.js

@@ -43 +43 @@
                 'deleting': 'Deleting...',
                 'deleteFailed': 'Deletion failed: %s',
-                'deleted': 'Deleted!',
+                'pluginDeleted': 'Deleted!',
+                'themeDeleted': 'Deleted!',
                 'livePreview': 'Live Preview',
                 'activatePlugin': 'Activate',