Changeset 40036 for trunk/tests/phpunit/tests/customize/setting.php

Timestamp:

02/01/2017 01:39:39 AM (8 years ago)

Author:

westonruter

Message:

Customize: Ensure root values are accessible in multidimensional custom setting types.

Fixes bad conditions in WP_Customize_Setting::get_root_value() and WP_Customize_Setting::set_root_value().

Props dlh.
Amends [35007].
See #32103.
Fixes #36952.

File:

• trunk/tests/phpunit/tests/customize/setting.php (modified) (2 diffs)

trunk/tests/phpunit/tests/customize/setting.php

@@ -403 +403 @@
             'sanitize_callback' => array( $this->manager->nav_menus, 'intval_base10' ),
         ) );
+
+        /*
+         * In #36952 the conditions were such that get_theme_mod() be erroneously used
+         * to source the root value for a custom multidimensional type.
+         * Add a theme mod with the same name as the custom setting to test fix.
+         */
+        set_theme_mod( $setting_id, 999 );
         $this->assertSame( 123, $setting->value() );
+
         $this->manager->set_post_value( $setting_id, '456' );
         $setting->preview();
@@ -409 +417 @@
 
         unset( $this->custom_type_data_previewed, $this->custom_type_data_saved );
+        remove_theme_mod( $setting_id );
     }