Changeset 40039

Timestamp:

02/03/2017 08:57:38 PM (9 years ago)

Author:

SergeyBiryukov

Message:

Media: In wp_unique_filename(), use explicit type casting when incrementing $number.

This prevents the "non-numeric value encountered" warning in PHP 7.1, caused by trying to increment an empty string on the first loop iteration.

Props drrobotnik for initial patch.
Fixes #39774.

File:

• trunk/src/wp-includes/functions.php (modified) (2 diffs)

trunk/src/wp-includes/functions.php

@@ -2064 +2064 @@
                         // Check for both lower and upper case extension or image sub-sizes may be overwritten.
                         while ( file_exists($dir . "/$filename") || file_exists($dir . "/$filename2") ) {
-                                $new_number = $number + 1;
+                                $new_number = (int) $number + 1;
                                 $filename = str_replace( array( "-$number$ext", "$number$ext" ), "-$new_number$ext", $filename );
                                 $filename2 = str_replace( array( "-$number$ext2", "$number$ext2" ), "-$new_number$ext2", $filename2 );
@@ -2084 +2084 @@
 
                 while ( file_exists( $dir . "/$filename" ) ) {
+                        $new_number = (int) $number + 1;
                         if ( '' == "$number$ext" ) {
-                                $filename = "$filename-" . ++$number;
+                                $filename = "$filename-" . $new_number;
                         } else {
-                                $filename = str_replace( array( "-$number$ext", "$number$ext" ), "-" . ++$number . $ext, $filename );
+                                $filename = str_replace( array( "-$number$ext", "$number$ext" ), "-" . $new_number . $ext, $filename );
                         }
+                        $number = $new_number;
                 }
         }