Changeset 40049

Timestamp:

02/06/2017 07:38:36 PM (8 years ago)

Author:

swissspidy

Message:

Taxonomy: Disallow overriding the name property when registering a taxonomy.

Props wpfo for initial patch.
Fixes #39308.

Location:

trunk

Files:

• src/wp-includes/class-wp-taxonomy.php (modified) (1 diff)
• tests/phpunit/tests/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-taxonomy.php

@@ -334 +334 @@
         }
 
+        $args['name'] = $this->name;
+
         foreach ( $args as $property_name => $property_value ) {
             $this->$property_name = $property_value;

trunk/tests/phpunit/tests/taxonomy.php

@@ -711 +711 @@
     }
 
+    /**
+     * @ticket 39308
+     */
+    public function test_taxonomy_name_property_should_not_get_overridden_by_passed_args() {
+        register_taxonomy( 'foo', 'post', array( 'name' => 'bar' ) );
+
+        $taxonomy = get_taxonomy( 'foo' );
+        unregister_taxonomy( 'foo' );
+
+        $this->assertSame( 'foo', $taxonomy->name );
+    }
 }