WordPress.org

Make WordPress Core

Changeset 40049


Ignore:
Timestamp:
02/06/2017 07:38:36 PM (5 years ago)
Author:
swissspidy
Message:

Taxonomy: Disallow overriding the name property when registering a taxonomy.

Props wpfo for initial patch.
Fixes #39308.

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-taxonomy.php

    r38747 r40049  
    334334        }
    335335
     336        $args['name'] = $this->name;
     337
    336338        foreach ( $args as $property_name => $property_value ) {
    337339            $this->$property_name = $property_value;
  • trunk/tests/phpunit/tests/taxonomy.php

    r38571 r40049  
    711711    }
    712712
     713    /**
     714     * @ticket 39308
     715     */
     716    public function test_taxonomy_name_property_should_not_get_overridden_by_passed_args() {
     717        register_taxonomy( 'foo', 'post', array( 'name' => 'bar' ) );
     718
     719        $taxonomy = get_taxonomy( 'foo' );
     720        unregister_taxonomy( 'foo' );
     721
     722        $this->assertSame( 'foo', $taxonomy->name );
     723    }
    713724}
Note: See TracChangeset for help on using the changeset viewer.