Changeset 40078 for branches/4.7

Timestamp:

02/19/2017 03:18:38 AM (8 years ago)

Author:

rachelbaker

Message:

REST API: Cast revision author ID to int.

The post_author field is a string internally, but we need to cast it to an integer in the REST API. This was already done for posts, but not for revisions. The field is already declared as an integer in both controllers.

Props jnylen0.
Merges [40063] to the 4.7 branch.
Fixes #39871.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-revisions-controller.php (modified) (2 diffs)

branches/4.7/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

@@ -345 +345 @@
 
         if ( ! empty( $schema['properties']['author'] ) ) {
-            $data['author'] = $post->post_author;
+            $data['author'] = (int) $post->post_author;
         }
 

branches/4.7/tests/phpunit/tests/rest-api/rest-revisions-controller.php

@@ -28 +28 @@
         ) );
 
+        wp_set_current_user( self::$editor_id );
         wp_update_post( array( 'post_content' => 'This content is better.', 'ID' => self::$post_id ) );
         wp_update_post( array( 'post_content' => 'This content is marvelous.', 'ID' => self::$post_id ) );
+        wp_set_current_user( 0 );
     }
 
@@ -137 +139 @@
         $data = $response->get_data();
         $this->assertEqualSets( $fields, array_keys( $data ) );
+        $this->assertSame( self::$editor_id, $data['author'] );
     }