Changeset 40080

Timestamp:

02/19/2017 04:31:12 AM (8 years ago)

Author:

rachelbaker

Message:

REST API: Include the status property in view context responses from the Posts endpoints.

Previously the status for a Post (or other post_types) was only exposed under the edit context, which doesn't really make much sense considering we support querying by post status without authentication. Originally introduced in v2.0 beta 1: ​https://github.com/WP-API/WP-API/commit/69f617d749e4f165b9e31c1c042eec45ade3e41f without any explanation in the commit message.

Props dhanendran, jnylen0, rachelbaker.
Fixes #39466.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• tests/phpunit/includes/testcase-rest-post-type-controller.php (modified) (1 diff)
• tests/qunit/fixtures/wp-api-generated.js (modified) (6 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1768 +1768 @@
                     'type'        => 'string',
                     'enum'        => array_keys( get_post_stati( array( 'internal' => false ) ) ),
-                    'context'     => array( 'edit' ),
+                    'context'     => array( 'view', 'edit' ),
                 ),
                 'type'            => array(

trunk/tests/phpunit/includes/testcase-rest-post-type-controller.php

@@ -135 +135 @@
         }
 
+        $this->assertEquals( $post->post_status, $data['status'] );
         $this->assertEquals( $post->guid, $data['guid']['rendered'] );
 
         if ( 'edit' === $context ) {
             $this->assertEquals( $post->guid, $data['guid']['raw'] );
-            $this->assertEquals( $post->post_status, $data['status'] );
 
             if ( '0000-00-00 00:00:00' === $post->post_date_gmt ) {

trunk/tests/qunit/fixtures/wp-api-generated.js

@@ -3385 +3385 @@
         "modified_gmt": "2017-02-14T00:00:00",
         "slug": "restapi-client-fixture-post",
+        "status": "publish",
         "type": "post",
         "link": "http://example.org/?p=3",
@@ -3475 +3476 @@
     "modified_gmt": "2017-02-14T00:00:00",
     "slug": "restapi-client-fixture-post",
+    "status": "publish",
     "type": "post",
     "link": "http://example.org/?p=3",
@@ -3553 +3555 @@
         "modified_gmt": "2017-02-14T00:00:00",
         "slug": "restapi-client-fixture-page",
+        "status": "publish",
         "type": "page",
         "link": "http://example.org/?page_id=5",
@@ -3627 +3630 @@
     "modified_gmt": "2017-02-14T00:00:00",
     "slug": "restapi-client-fixture-page",
+    "status": "publish",
     "type": "page",
     "link": "http://example.org/?page_id=5",
@@ -3701 +3705 @@
         "modified_gmt": "2017-02-14T00:00:00",
         "slug": "restapi-client-fixture-attachment",
+        "status": "inherit",
         "type": "attachment",
         "link": "http://example.org/?attachment_id=7",
@@ -3759 +3764 @@
     "modified_gmt": "2017-02-14T00:00:00",
     "slug": "restapi-client-fixture-attachment",
+    "status": "inherit",
     "type": "attachment",
     "link": "http://example.org/?attachment_id=7",