Changeset 40092

Timestamp:

02/21/2017 03:50:13 AM (10 years ago)

Author:

dd32

Message:

Menus: Prevent notice thrown in class-walker-page.php.

Calling Walker_Page::walk() directly was causing an Undefined index: item_spacing notice to be thrown, this adds an isset() check to prevent it.

Props bhargavbhandari90, peterwilsoncc.
Merges [39949] to the 4.7 branch.
Fixes #39564.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-includes/class-walker-page.php (modified) (4 diffs)

branches/4.7/src/wp-includes/class-walker-page.php

@@ -54 +54 @@
          */
         public function start_lvl( &$output, $depth = 0, $args = array() ) {
-                if ( 'preserve' === $args['item_spacing'] ) {
+                if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) {
                         $t = "\t";
                         $n = "\n";
@@ -79 +79 @@
          */
         public function end_lvl( &$output, $depth = 0, $args = array() ) {
-                if ( 'preserve' === $args['item_spacing'] ) {
+                if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) {
                         $t = "\t";
                         $n = "\n";
@@ -104 +104 @@
          */
         public function start_el( &$output, $page, $depth = 0, $args = array(), $current_page = 0 ) {
-                if ( 'preserve' === $args['item_spacing'] ) {
+                if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) {
                         $t = "\t";
                         $n = "\n";
@@ -197 +197 @@
          */
         public function end_el( &$output, $page, $depth = 0, $args = array() ) {
-                if ( 'preserve' === $args['item_spacing'] ) {
+                if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) {
                         $t = "\t";
                         $n = "\n";