Changeset 40096

Timestamp:

02/21/2017 06:55:18 AM (8 years ago)

Author:

dd32

Message:

Customize: Skip intercepting non-HTTP(S) links in customizer preview just as jump links are ignored.

Ensures that links with javascript:, mailto: and other protocols work as expected in the customizer preview.

Props westonruter.
Merges [40064] to the 4.7 branch.
Fixes #39797.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-includes/js/customize-preview.js (modified) (2 diffs)

branches/4.7/src/wp-includes/js/customize-preview.js

@@ -146 +146 @@
             }
 
+            // Allow internal jump links and JS links to behave normally without preventing default.
             isInternalJumpLink = ( '#' === link.attr( 'href' ).substr( 0, 1 ) );
-
-            // Allow internal jump links to behave normally without preventing default.
-            if ( isInternalJumpLink ) {
+            if ( isInternalJumpLink || ! /^https?:$/.test( link.prop( 'protocol' ) ) ) {
                 return;
             }
@@ -335 +334 @@
         }
 
-        // Ignore links with href="#" or href="#id".
-        if ( '#' === $( element ).attr( 'href' ).substr( 0, 1 ) ) {
+        // Ignore links with href="#", href="#id", or non-HTTP protocols (e.g. javascript: and mailto:).
+        if ( '#' === $( element ).attr( 'href' ).substr( 0, 1 ) || ! /^https?:$/.test( element.protocol ) ) {
             return;
         }