Changeset 40101 for trunk/tests/phpunit/tests/rest-api.php

Timestamp:

02/21/2017 06:17:32 PM (8 years ago)

Author:

jnylen0

Message:

REST API: Fix multiple issues with setting dates of posts and comments.

This commit modifies the rest_get_date_with_gmt function to correctly parse local and UTC timestamps with or without timezone information.

It also ensures that the REST API can edit the dates of draft posts by setting the edit_date flag to wp_update_post.

Overall this commit ensures that post and comment dates can be set and updated as expected.

Fixes #39256.

File:

• trunk/tests/phpunit/tests/rest-api.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api.php

@@ -384 +384 @@
     }
 
+    public function rest_date_provider() {
+        return array(
+            // Valid dates with timezones
+            array( '2017-01-16T11:30:00-05:00', gmmktime( 11, 30,  0,  1, 16, 2017 ) + 5 * HOUR_IN_SECONDS ),
+            array( '2017-01-16T11:30:00-05:30', gmmktime( 11, 30,  0,  1, 16, 2017 ) + 5.5 * HOUR_IN_SECONDS ),
+            array( '2017-01-16T11:30:00-05'   , gmmktime( 11, 30,  0,  1, 16, 2017 ) + 5 * HOUR_IN_SECONDS ),
+            array( '2017-01-16T11:30:00+05'   , gmmktime( 11, 30,  0,  1, 16, 2017 ) - 5 * HOUR_IN_SECONDS ),
+            array( '2017-01-16T11:30:00-00'   , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+            array( '2017-01-16T11:30:00+00'   , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+            array( '2017-01-16T11:30:00Z'     , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+
+            // Valid dates without timezones
+            array( '2017-01-16T11:30:00'      , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+
+            // Invalid dates (TODO: support parsing partial dates as ranges, see #38641)
+            array( '2017-01-16T11:30:00-5', false ),
+            array( '2017-01-16T11:30', false ),
+            array( '2017-01-16T11', false ),
+            array( '2017-01-16T', false ),
+            array( '2017-01-16', false ),
+            array( '2017-01', false ),
+            array( '2017', false ),
+        );
+    }
+
+    /**
+     * @dataProvider rest_date_provider
+     */
+    public function test_rest_parse_date( $string, $value ) {
+        $this->assertEquals( $value, rest_parse_date( $string ) );
+    }
+
+    public function rest_date_force_utc_provider() {
+        return array(
+            // Valid dates with timezones
+            array( '2017-01-16T11:30:00-05:00', gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+            array( '2017-01-16T11:30:00-05:30', gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+            array( '2017-01-16T11:30:00-05'   , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+            array( '2017-01-16T11:30:00+05'   , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+            array( '2017-01-16T11:30:00-00'   , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+            array( '2017-01-16T11:30:00+00'   , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+            array( '2017-01-16T11:30:00Z'     , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+
+            // Valid dates without timezones
+            array( '2017-01-16T11:30:00'      , gmmktime( 11, 30,  0,  1, 16, 2017 ) ),
+
+            // Invalid dates (TODO: support parsing partial dates as ranges, see #38641)
+            array( '2017-01-16T11:30:00-5', false ),
+            array( '2017-01-16T11:30', false ),
+            array( '2017-01-16T11', false ),
+            array( '2017-01-16T', false ),
+            array( '2017-01-16', false ),
+            array( '2017-01', false ),
+            array( '2017', false ),
+        );
+    }
+
+    /**
+     * @dataProvider rest_date_force_utc_provider
+     */
+    public function test_rest_parse_date_force_utc( $string, $value ) {
+        $this->assertEquals( $value, rest_parse_date( $string, true ) );
+    }
 }