Changeset 40105 for trunk/tests/phpunit/tests/rest-api/rest-request.php

Timestamp:

02/23/2017 08:09:11 PM (9 years ago)

Author:

jnylen0

Message:

REST API: Correctly parse body parameters for DELETE requests.

DELETE was inadvertently omitted from the list of non-POST HTTP methods that should be able to accept body parameters. Parameters passed to DELETE requests as JSON are already parsed correctly; this commit fixes application/x-www-form-urlencoded parameters as well.

Props mnelson4.
Fixes #39933.

File:

• trunk/tests/phpunit/tests/rest-api/rest-request.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-request.php

@@ -204 +204 @@
         }
 
+        public function non_post_http_methods_with_request_body_provider() {
+                return array(
+                        array( 'PUT' ),
+                        array( 'PATCH' ),
+                        array( 'DELETE' ),
+                );
+        }
+
         /**
-         * PUT requests don't get $_POST automatically parsed, so ensure that
-         * WP_REST_Request does it for us.
+         * Tests that methods supporting request bodies have access to the
+         * request's body.  For POST this is straightforward via `$_POST`; for
+         * other methods `WP_REST_Request` needs to parse the body for us.
+         *
+         * @dataProvider non_post_http_methods_with_request_body_provider
          */
-        public function test_parameters_for_put() {
+        public function test_non_post_body_parameters( $request_method ) {
                 $data = array(
                         'foo' => 'bar',
@@ -220 +231 @@
                         ),
                 );
-
-                $this->request->set_method( 'PUT' );
+                $this->request->set_method( $request_method );
                 $this->request->set_body_params( array() );
                 $this->request->set_body( http_build_query( $data ) );
-
                 foreach ( $data as $key => $expected_value ) {
                         $this->assertEquals( $expected_value, $this->request->get_param( $key ) );