Changeset 40115 for branches/4.7/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

Timestamp:

02/24/2017 10:02:48 PM (8 years ago)

Author:

SergeyBiryukov

Message:

REST API: Shim post_date_gmt for drafts / empty dates in the REST API.

Internally, WordPress uses a special post_date_gmt value of 0000-00-00 00:00:00 to indicate that a draft's date is "floating" and should be updated whenever the post is saved. This makes it much more difficult for API clients to know the correct date of a draft post.

This commit provides a best guess at a date_gmt value for draft posts in this situation using the date field and the site's current timezone offset.

Props joehoyle, jnylen0.
Merges [40108] to the 4.7 branch.
Fixes #38883.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (2 diffs)

branches/4.7/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1386 +1386 @@
 
         if ( ! empty( $schema['properties']['date_gmt'] ) ) {
-            $data['date_gmt'] = $this->prepare_date_response( $post->post_date_gmt );
+            // For drafts, `post_date_gmt` may not be set, indicating that the
+            // date of the draft should be updated each time it is saved (see
+            // #38883).  In this case, shim the value based on the `post_date`
+            // field with the site's timezone offset applied.
+            if ( '0000-00-00 00:00:00' === $post->post_date_gmt ) {
+                $post_date_gmt = date( 'Y-m-d H:i:s', strtotime( $post->post_date ) - ( get_option( 'gmt_offset' ) * 3600 ) );
+            } else {
+                $post_date_gmt = $post->post_date_gmt;
+            }
+            $data['date_gmt'] = $this->prepare_date_response( $post_date_gmt );
         }
 
@@ -1402 +1411 @@
 
         if ( ! empty( $schema['properties']['modified_gmt'] ) ) {
-            $data['modified_gmt'] = $this->prepare_date_response( $post->post_modified_gmt );
+            // For drafts, `post_modified_gmt` may not be set (see
+            // `post_date_gmt` comments above).  In this case, shim the value
+            // based on the `post_modified` field with the site's timezone
+            // offset applied.
+            if ( '0000-00-00 00:00:00' === $post->post_modified_gmt ) {
+                $post_modified_gmt = date( 'Y-m-d H:i:s', strtotime( $post->post_modified ) - ( get_option( 'gmt_offset' ) * 3600 ) );
+            } else {
+                $post_modified_gmt = $post->post_modified_gmt;
+            }
+            $data['modified_gmt'] = $this->prepare_date_response( $post_modified_gmt );
         }