Changeset 40115 for branches/4.7/tests/phpunit/includes/testcase-rest-post-type-controller.php

Timestamp:

02/24/2017 10:02:48 PM (10 years ago)

Author:

SergeyBiryukov

Message:

REST API: Shim post_date_gmt for drafts / empty dates in the REST API.

Internally, WordPress uses a special post_date_gmt value of 0000-00-00 00:00:00 to indicate that a draft's date is "floating" and should be updated whenever the post is saved. This makes it much more difficult for API clients to know the correct date of a draft post.

This commit provides a best guess at a date_gmt value for draft posts in this situation using the date field and the site's current timezone offset.

Props joehoyle, jnylen0.
Merges [40108] to the 4.7 branch.
Fixes #38883.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• tests/phpunit/includes/testcase-rest-post-type-controller.php (modified) (2 diffs)

branches/4.7/tests/phpunit/includes/testcase-rest-post-type-controller.php

@@ -11 +11 @@
                 $this->assertEquals( get_permalink( $post->ID ), $data['link'] );
                 if ( '0000-00-00 00:00:00' === $post->post_date_gmt ) {
-                        $this->assertNull( $data['date_gmt'] );
+                        $post_date_gmt = date( 'Y-m-d H:i:s', strtotime( $post->post_date ) - ( get_option( 'gmt_offset' ) * 3600 ) );
+                        $this->assertEquals( mysql_to_rfc3339( $post_date_gmt ), $data['date_gmt'] );
+                } else {
+                        $this->assertEquals( mysql_to_rfc3339( $post->post_date_gmt ), $data['date_gmt'] );
                 }
                 $this->assertEquals( mysql_to_rfc3339( $post->post_date ), $data['date'] );
 
                 if ( '0000-00-00 00:00:00' === $post->post_modified_gmt ) {
-                        $this->assertNull( $data['modified_gmt'] );
+                        $post_modified_gmt = date( 'Y-m-d H:i:s', strtotime( $post->post_modified ) - ( get_option( 'gmt_offset' ) * 3600 ) );
+                        $this->assertEquals( mysql_to_rfc3339( $post_modified_gmt ), $data['modified_gmt'] );
+                } else {
+                        $this->assertEquals( mysql_to_rfc3339( $post->post_modified_gmt ), $data['modified_gmt'] );
                 }
                 $this->assertEquals( mysql_to_rfc3339( $post->post_modified ), $data['modified'] );
@@ -140 +146 @@
                 if ( 'edit' === $context ) {
                         $this->assertEquals( $post->guid, $data['guid']['raw'] );
-
-                        if ( '0000-00-00 00:00:00' === $post->post_date_gmt ) {
-                                $this->assertNull( $data['date_gmt'] );
-                        } else {
-                                $this->assertEquals( mysql_to_rfc3339( $post->post_date_gmt ), $data['date_gmt'] );
-                        }
-
-                        if ( '0000-00-00 00:00:00' === $post->post_modified_gmt ) {
-                                $this->assertNull( $data['modified_gmt'] );
-                        } else {
-                                $this->assertEquals( mysql_to_rfc3339( $post->post_modified_gmt ), $data['modified_gmt'] );
-                        }
                 }