Changeset 40145 for trunk/tests/phpunit/tests/term/wpInsertTerm.php

Timestamp:

03/03/2017 02:49:13 AM (10 years ago)

Author:

boonebgorges

Message:

Taxonomy: Take 'parent' into account when checking for terms with duplicate names.

Terms with duplicate names are not allowed at the same level of a
taxonomy hierarchy. The name lookup introduced in [34809] did not
properly account for the 'parent' parameter, with the result that
the duplicate-name restriction was tighter than intended (terms
with duplicate names could not be created at different levels of
a single hierarchy).

Props mikejolley.
Fixes #39984.

File:

• trunk/tests/phpunit/tests/term/wpInsertTerm.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/wpInsertTerm.php

@@ -394 +394 @@
                 $this->assertSame( $t1, $error->get_error_data() );
         }
+
+        /**
+         * @ticket 39984
+         */
+        public function test_error_should_reference_correct_term_when_rejected_as_duplicate() {
+                register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true ) );
+                $t1 = self::factory()->term->create( array(
+                        'name' => 'Foo',
+                        'slug' => 'foo',
+                        'taxonomy' => 'wptests_tax',
+                ) );
+
+                $t2 = self::factory()->term->create( array(
+                        'name' => 'Bar',
+                        'slug' => 'bar',
+                        'taxonomy' => 'wptests_tax',
+                ) );
+
+                $t1_child = wp_insert_term( 'Child', 'wptests_tax', array(
+                        'parent' => $t1,
+                ) );
+
+                $t2_child = wp_insert_term( 'Child', 'wptests_tax', array(
+                        'parent' => $t2,
+                ) );
+
+                $error = wp_insert_term( 'Child', 'wptests_tax', array(
+                        'parent' => $t2,
+                ) );
+
+                $this->assertWPError( $error );
+                $this->assertSame( 'term_exists', $error->get_error_code() );
+                $this->assertSame( $t2_child['term_id'], $error->get_error_data() );
+        }
+
         /**
          * @ticket 31328