Changeset 40237

Timestamp:

03/07/2017 05:26:51 AM (8 years ago)

Author:

jnylen0

Message:

WP_Query: Add missing tests for combinations of orderby and include parameters.

This commit adds some missing test cases for combinations of orderby and other parameters (post_parent__in and post_name__in).

Followup to [40056] for orderby and post__in.

The interaction of these parameters is perhaps counterintuitive because orderby does not affect the returned results. This is overall probably the best design, and it's now better tested and documented.

Props fibonaccina.
See #39055.

File:

• trunk/tests/phpunit/tests/query/results.php (modified) (2 diffs)

trunk/tests/phpunit/tests/query/results.php

@@ -369 +369 @@
      * @ticket 39055
      */
+    function test_query_orderby_post_parent__in_with_order_desc() {
+        $post_parent__in_array = array( self::$parent_two, self::$parent_one );
+        $expected_returned_array = array( 'child-three', 'child-four', 'child-one', 'child-two' );
+
+        $posts = $this->q->query( array(
+            'post_parent__in' => $post_parent__in_array,
+            'orderby'         => 'post_parent__in',
+            'order'           => 'desc',
+        ) );
+
+        // order=desc does not influence the order of returned results (returns same order as order=asc)
+        $this->assertEquals( $expected_returned_array, wp_list_pluck( $posts, 'post_title' ) );
+    }
+
+    /**
+     * @ticket 39055
+     */
     function test_query_orderby_post__in_with_no_order_specified() {
         $post__in_array = array( self::$post_ids[2], self::$post_ids[0], self::$post_ids[1] );
@@ -418 +435 @@
         // Order=desc does not have an effect on the order of returned results
         $this->assertSame( $expected_returned_array, $q->posts );
+    }
+
+    /**
+     * @ticket 39055
+     */
+    function test_query_orderby_post_name__in_with_order_asc() {
+        $post_name__in_array = array( 'parent-two', 'parent-one', 'parent-three' );
+
+        $q = new WP_Query( array(
+            'post_name__in' => $post_name__in_array,
+            'orderby'       => 'post_name__in',
+            'order'         => 'asc'
+        ) );
+
+        $this->assertSame( $post_name__in_array, array_unique( wp_list_pluck( $q->posts, 'post_title' ) ) );
+    }
+
+    /**
+     * @ticket 39055
+     */
+    function test_query_orderby_post_name__in_with_order_desc() {
+        $post_name__in_array = array( 'parent-two', 'parent-one', 'parent-three' );
+
+        $q = new WP_Query( array(
+            'post_name__in' => $post_name__in_array,
+            'orderby'       => 'post_name__in',
+            'order'         => 'desc'
+        ) );
+
+        // order=desc does not influence the order of returned results (returns same order as order=asc)
+        $this->assertSame( $post_name__in_array, array_unique( wp_list_pluck( $q->posts, 'post_title' ) ) );
     }