Changeset 40275 for trunk/tests/phpunit/tests/term/getTermBy.php

Timestamp:

03/11/2017 02:26:11 AM (8 years ago)

Author:

boonebgorges

Message:

Don't run 'get_terms' filter when querying for terms within get_term_by().

Historically, it has been possible to call get_term_by() within
a 'get_terms' filter callback. Since get_term_by() was refactored
to use get_terms() internally [38677], callbacks of this nature
have resulted in infinite loops.

As a workaround, we introduce a 'suppress_filter' option to get_terms(),
and use it when calling the function from within get_term_by().

Props ocean90.
See #21760.

File:

• trunk/tests/phpunit/tests/term/getTermBy.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/getTermBy.php

@@ -193 +193 @@
         $this->assertContains( 'LIMIT 1', $wpdb->last_query );
     }
+
+    /**
+     * @ticket 21760
+     */
+    public function test_prevent_recursion_by_get_terms_filter() {
+        $action = new MockAction();
+
+        add_filter( 'get_terms', array( $action, 'filter' ) );
+        get_term_by( 'name', 'burrito', 'post_tag' );
+        remove_filter( 'get_terms', array( $action, 'filter' ) );
+
+        $this->assertEquals( 0, $action->get_call_count() );
+    }
 }