Context Navigation

← Previous Change
Next Change →

getTermBy.php

Timestamp:

03/16/2017 02:03:53 AM (9 years ago)

Author:

boonebgorges

Message:

Improve querying for terms with falsey names and slugs.

Prior to [38677], get_term_by() would always return false if
an empty string were passed as the queried 'name' or 'slug'. The
refactor to use get_terms() broke this behavior; inappropriately
imprecise empty() checks caused the 'name' or 'slug' clause to be
discarded altogether when fetching terms, resulting in an incorrect
term being returned from the function.

We fix the regression by special-casing truly empty values passed
to get_term_by(), and ensuring that WP_Term_Query is properly
able to handle 0 and '0' term queries.

Props sstoqnov.
Fixes #21760.

File:

: 1 edited

trunk/tests/phpunit/tests/term/getTermBy.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/term/getTermBy.php

-              r40275
+              r40293
                 $this->assertEquals( 0, $action->get_call_count() );
+        }
+        /**
+         * @ticket 21760
+         */
+        public function test_get_term_by_name_with_string_0() {
+                register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true ) );
+                $term_id = $this->factory->term->create( array(
+                        'name'     => '0',
+                        'taxonomy' => 'wptests_tax',
+                ) );
+                $found = get_term_by( 'name', '0', 'wptests_tax' );
+                $this->assertSame( $term_id, $found->term_id );
+        }
+        /**
+         * @ticket 21760
+         */
+        public function test_get_term_by_slug_with_string_0() {
+                register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true ) );
+                $term_id = $this->factory->term->create( array(
+                        'taxonomy' => 'wptests_tax',
+                        'name'     => '0',
+                        'slug'     => '0',
+                ) );
+                $found = get_term_by( 'slug', '0', 'wptests_tax' );
+                $this->assertSame( $term_id, $found->term_id );
+        }
+        /**
+         * @ticket 21760
+         */
+        public function test_get_term_by_with_empty_string() {
+                register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true ) );
+                $found_by_slug = get_term_by( 'slug', '', 'wptests_tax' );
+                $found_by_name = get_term_by( 'name', '', 'wptests_tax' );
+                $this->assertFalse( $found_by_slug );
+                $this->assertFalse( $found_by_name );
+        }
+}

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 40293 for trunk/tests/phpunit/tests/term/getTermBy.php

Legend:

trunk/tests/phpunit/tests/term/getTermBy.php

Download in other formats: