Context Navigation

← Previous Change
Next Change →

getTerms.php

Timestamp:

03/16/2017 02:03:53 AM (9 years ago)

Author:

boonebgorges

Message:

Improve querying for terms with falsey names and slugs.

Prior to [38677], get_term_by() would always return false if
an empty string were passed as the queried 'name' or 'slug'. The
refactor to use get_terms() broke this behavior; inappropriately
imprecise empty() checks caused the 'name' or 'slug' clause to be
discarded altogether when fetching terms, resulting in an incorrect
term being returned from the function.

We fix the regression by special-casing truly empty values passed
to get_term_by(), and ensuring that WP_Term_Query is properly
able to handle 0 and '0' term queries.

Props sstoqnov.
Fixes #21760.

File:

: 1 edited

trunk/tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/term/getTerms.php

-              r38382
+              r40293
+        }
+        /**
+         * @ticket 21760
+         */
+        public function test_with_term_slug_equal_to_string_0() {
+                register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true ) );
+                $term_id = self::factory()->term->create( array(
+                        'name' => '0',
+                        'slug' => '0',
+                        'taxonomy' => 'wptests_tax',
+                ) );
+                $found = get_terms( array(
+                        'taxonomy'   => 'wptests_tax',
+                        'hide_empty' => 0,
+                        'slug'       => '0',
+                ) );
+                $this->assertEqualSets( array( $term_id ), wp_list_pluck( $found, 'term_id' ) );
+        }
+        /**
+         * @ticket 21760
+         */
+        public function test_with_multiple_term_slugs_one_equal_to_string_0() {
+                register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true ) );
+                $term_id1 = self::factory()->term->create( array(
+                        'name'     => '0',
+                        'slug'     => '0',
+                        'taxonomy' => 'wptests_tax',
+                ) );
+                $term_id2 = self::factory()->term->create( array(
+                        'name'     => 'Test',
+                        'slug'     => 'test',
+                        'taxonomy' => 'wptests_tax',
+                ) );
+                $found = get_terms( array(
+                        'taxonomy'   => 'wptests_tax',
+                        'hide_empty' => 0,
+                        'slug'       => array(
+                                '0',
+                                'test',
+                        ),
+                ) );
+                $this->assertEqualSets( array( $term_id1, $term_id2 ), wp_list_pluck( $found, 'term_id' ) );
+        }
         protected function create_hierarchical_terms_and_posts() {
                 $terms = array();

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 40293 for trunk/tests/phpunit/tests/term/getTerms.php

Legend:

trunk/tests/phpunit/tests/term/getTerms.php

Download in other formats: