Changeset 40300 for trunk

Timestamp:

03/18/2017 03:22:08 AM (8 years ago)

Author:

westonruter

Message:

Customize: Trailingslash the home nav menu item URL in starter content.

This prevents an additional 301 redirect when clicking on the nav menu item, and it also prevents a scenario where the auth cookie may not be passed and cause an authentication error when navigating in the customizer.

Props dlh, swissspidy.
Fixes #40112.

Location:

trunk

Files:

• src/wp-includes/theme.php (modified) (1 diff)
• tests/phpunit/tests/customize/manager.php (modified) (1 diff)

trunk/src/wp-includes/theme.php

@@ -1985 +1985 @@
                 'type' => 'custom',
                 'title' => _x( 'Home', 'Theme starter content' ),
-                'url' => home_url(),
+                'url' => home_url( '/' ),
             ),
             'page_home' => array( // Deprecated in favor of link_home.

trunk/tests/phpunit/tests/customize/manager.php

@@ -491 +491 @@
         $this->assertEquals( 0, $changeset_values['nav_menu_item[-1]']['object_id'] );
         $this->assertEquals( 'custom', $changeset_values['nav_menu_item[-1]']['type'] );
-        $this->assertEquals( home_url(), $changeset_values['nav_menu_item[-1]']['url'] );
+        $this->assertEquals( home_url( '/' ), $changeset_values['nav_menu_item[-1]']['url'] );
 
         $this->assertEmpty( $wp_customize->changeset_data() );