Changeset 40306 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Timestamp:

03/20/2017 04:29:50 AM (8 years ago)

Author:

rachelbaker

Message:

REST API: Confirm the parent post object of an attachment exists in WP_REST_Posts_Controller::check_read_permission().

Avoid a PHP Error when attempting to embed the parent post of an attachment, when the parent post ID is invalid. Instead check if the parent post object exists before checking the read permission for the parent post.

Props GhostToast.
Fixes #39881.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -479 +479 @@
         $response = $this->server->dispatch( $request );
         $this->assertEquals( 403, $response->get_status() );
+    }
+
+    public function test_get_item_inherit_status_with_invalid_parent() {
+        $attachment_id = $this->factory->attachment->create_object( $this->test_file, REST_TESTS_IMPOSSIBLY_HIGH_NUMBER, array(
+            'post_mime_type' => 'image/jpeg',
+            'post_excerpt'   => 'A sample caption',
+        ) );
+        $request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/media/%d', $attachment_id ) );
+        $response = $this->server->dispatch( $request );
+        $data = $response->get_data();
+
+        $this->assertEquals( 200, $response->get_status() );
+        $this->assertEquals( $attachment_id, $data['id'] );
+    }
+
+    public function test_get_item_auto_status_with_invalid_parent_returns_error() {
+        $attachment_id = $this->factory->attachment->create_object( $this->test_file, REST_TESTS_IMPOSSIBLY_HIGH_NUMBER, array(
+            'post_mime_type' => 'image/jpeg',
+            'post_excerpt'   => 'A sample caption',
+            'post_status'    => 'auto-draft',
+        ) );
+        $request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/media/%d', $attachment_id ) );
+        $response = $this->server->dispatch( $request );
+
+        $this->assertErrorResponse( 'rest_forbidden', $response, 403 );
     }