Changeset 40324

Timestamp:

03/24/2017 05:31:54 PM (8 years ago)

Author:

swissspidy

Message:

REST API: Use get_gmt_from_date() when preparing a draft post for response.

This prevents wrong dates when dealing with DST, see [40115] and [40284].

Props nerrad.
Fixes #40136.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1402 +1402 @@
             // field with the site's timezone offset applied.
             if ( '0000-00-00 00:00:00' === $post->post_date_gmt ) {
-                $post_date_gmt = date( 'Y-m-d H:i:s', strtotime( $post->post_date ) - ( get_option( 'gmt_offset' ) * 3600 ) );
+                $post_date_gmt = get_gmt_from_date( $post->post_date );
             } else {
                 $post_date_gmt = $post->post_date_gmt;

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -2243 +2243 @@
 
         wp_set_current_user( self::$editor_id );
-        update_option( 'timezone_string', '' );
-        update_option( 'gmt_offset', -6 );
+        update_option( 'timezone_string', 'America/Chicago' );
 
         // Need to set dates using wpdb directly because `wp_update_post` and
@@ -2289 +2288 @@
 
         update_option( 'timezone_string', '' );
-        update_option( 'gmt_offset', 0 );
     }